From ceb2eb21d8500b3a1273570f779370554cd2c4ab Mon Sep 17 00:00:00 2001 From: Arthur Baars Date: Thu, 8 Apr 2021 15:11:57 +0200 Subject: [PATCH] Address comments --- ql/src/codeql_ruby/ast/Module.qll | 2 -- .../codeql_ruby/controlflow/internal/ControlFlowGraphImpl.qll | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/ql/src/codeql_ruby/ast/Module.qll b/ql/src/codeql_ruby/ast/Module.qll index 98aee1e1746..6616e29a899 100644 --- a/ql/src/codeql_ruby/ast/Module.qll +++ b/ql/src/codeql_ruby/ast/Module.qll @@ -8,8 +8,6 @@ private import internal.TreeSitter * A representation of a run-time `module` or `class` value. */ class Module extends TModule { - Module() { this = TResolved(_) or this = TUnresolved(_) } - /** Get a declaration of this module, if any. */ ModuleBase getADeclaration() { result.getModule() = this } diff --git a/ql/src/codeql_ruby/controlflow/internal/ControlFlowGraphImpl.qll b/ql/src/codeql_ruby/controlflow/internal/ControlFlowGraphImpl.qll index 32ccfb319e9..a648a2c1b71 100644 --- a/ql/src/codeql_ruby/controlflow/internal/ControlFlowGraphImpl.qll +++ b/ql/src/codeql_ruby/controlflow/internal/ControlFlowGraphImpl.qll @@ -598,7 +598,7 @@ module Trees { private class CharacterTree extends LeafTree, CharacterLiteral { } - private class ClassTree extends BodyStmtPreOrderTree, ClassDeclaration { + private class ClassDeclarationTree extends BodyStmtPreOrderTree, ClassDeclaration { /** Gets the `i`th child in the body of this block. */ final override AstNode getBodyChild(int i, boolean rescuable) { result = this.getScopeExpr() and i = 0 and rescuable = false @@ -934,7 +934,7 @@ module Trees { } } - private class ModuleTree extends BodyStmtPreOrderTree, ModuleDeclaration { + private class ModuleDeclarationTree extends BodyStmtPreOrderTree, ModuleDeclaration { /** Gets the `i`th child in the body of this block. */ final override AstNode getBodyChild(int i, boolean rescuable) { result = this.getScopeExpr() and i = 0 and rescuable = false