hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 19:55:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Rename FlowSteps::callback -> exploratoryCallbackStep

Browse Source
This commit is contained in:
Asger Feldthaus
2021-09-08 11:08:40 +02:00
parent 7c94dd94e9
commit ceaf2b3727
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javascript/ql/lib/semmle/javascript/dataflow/Configuration.qll
View File

@@ -947,7 +947,7 @@ private predicate exploratoryFlowStep(
isAdditionalLoadStoreStep(pred, succ, _, _, cfg) or
// the following three disjuncts taken together over-approximate flow through
// higher-order calls
callback(pred, succ) or
exploratoryCallbackStep(pred, succ) or
succ = pred.(DataFlow::FunctionNode).getAParameter() or
exploratoryBoundInvokeStep(pred, succ)
}

2
javascript/ql/lib/semmle/javascript/dataflow/TrackedNodes.qll
View File

@@ -154,7 +154,7 @@ private module NodeTracking {
or
basicLoadStep(mid, nd, _)
or
callback(mid, nd)
exploratoryCallbackStep(mid, nd)
or
nd = mid.(DataFlow::FunctionNode).getAParameter()
)

4
javascript/ql/lib/semmle/javascript/dataflow/internal/FlowSteps.qll
View File

@@ -434,7 +434,7 @@ private module CachedSteps {
* invocation.
*/
cached
predicate callback(DataFlow::Node arg, DataFlow::SourceNode cb) {
predicate exploratoryCallbackStep(DataFlow::Node arg, DataFlow::SourceNode cb) {
Stages::TypeTracking::ref() and
exists(DataFlow::InvokeNode invk, DataFlow::ParameterNode cbParm, DataFlow::Node cbArg |
arg = invk.getAnArgument() and
@@ -444,7 +444,7 @@ private module CachedSteps {
)
or
exists(DataFlow::ParameterNode cbParm, DataFlow::Node cbArg |
callback(arg, cbParm) and
exploratoryCallbackStep(arg, cbParm) and
callStep(cbArg, cbParm) and
cb.flowsTo(cbArg)
)