hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

JS: Change signature of isShadowedFromBulkExport

Browse Source
This commit is contained in:
Asger F
2025-11-21 12:30:31 +01:00
parent 613895e0c0
commit ce9986c449
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
javascript/ql/lib/semmle/javascript/ES2015Modules.qll
View File

@@ -423,7 +423,7 @@ class BulkReExportDeclaration extends ReExportDeclaration, @export_all_declarati
overlay[global] overlay[global]
override predicate exportsAs(LexicalName v, string name) { override predicate exportsAs(LexicalName v, string name) {
this.getReExportedES2015Module().exportsAs(v, name) and this.getReExportedES2015Module().exportsAs(v, name) and
not isShadowedFromBulkExport(this, name) not isShadowedFromBulkExport(this.getEnclosingModule(), name)
} }
overlay[global] overlay[global]
@@ -433,8 +433,8 @@ class BulkReExportDeclaration extends ReExportDeclaration, @export_all_declarati
} }
/** /**
* Holds if the given bulk export `reExport` should not re-export `name` because there is an explicit export * Holds if bulk re-exports in `mod` should not re-export `name` because there is an explicit export
* of that name in the same module. * of that name in `mod`.
* *
* At compile time, shadowing works across declaration spaces. * At compile time, shadowing works across declaration spaces.
* For instance, directly exporting an interface `X` will block a variable `X` from being re-exported: * For instance, directly exporting an interface `X` will block a variable `X` from being re-exported:
@@ -446,8 +446,8 @@ class BulkReExportDeclaration extends ReExportDeclaration, @export_all_declarati
* but we ignore this subtlety. * but we ignore this subtlety.
*/ */
overlay[global] overlay[global]
private predicate isShadowedFromBulkExport(BulkReExportDeclaration reExport, string name) { private predicate isShadowedFromBulkExport(Module mod, string name) {
exists(ExportNamedDeclaration other | other.getTopLevel() = reExport.getEnclosingModule() | exists(ExportNamedDeclaration other | other.getTopLevel() = mod |
other.getAnExportedDecl().getName() = name other.getAnExportedDecl().getName() = name
or or
other.getASpecifier().getExportedName() = name other.getASpecifier().getExportedName() = name