Python: Move dataflow tests out of experimental

python/ql/test/library-tests/dataflow/callgraph_crosstalk/Arguments.expected

@@ -0,0 +1,13 @@
+| test.py:32:8:32:23 | CrosstalkTestX() | test.py:9:5:9:23 | Function __init__ | test.py:32:8:32:23 | [pre] ControlFlowNode for CrosstalkTestX() | self |
+| test.py:33:8:33:23 | CrosstalkTestY() | test.py:21:5:21:23 | Function __init__ | test.py:33:8:33:23 | [pre] ControlFlowNode for CrosstalkTestY() | self |
+| test.py:43:1:43:8 | func() | test.py:13:5:13:26 | Function setx | test.py:36:12:36:15 | ControlFlowNode for objx | self |
+| test.py:43:1:43:8 | func() | test.py:13:5:13:26 | Function setx | test.py:43:6:43:7 | ControlFlowNode for IntegerLiteral | position 0 |
+| test.py:43:1:43:8 | func() | test.py:25:5:25:26 | Function sety | test.py:38:12:38:15 | ControlFlowNode for objy | self |
+| test.py:43:1:43:8 | func() | test.py:25:5:25:26 | Function sety | test.py:43:6:43:7 | ControlFlowNode for IntegerLiteral | position 0 |
+| test.py:51:1:51:8 | func() | test.py:16:5:16:30 | Function setvalue | test.py:47:12:47:15 | ControlFlowNode for objx | self |
+| test.py:51:1:51:8 | func() | test.py:16:5:16:30 | Function setvalue | test.py:51:6:51:7 | ControlFlowNode for IntegerLiteral | position 0 |
+| test.py:51:1:51:8 | func() | test.py:28:5:28:30 | Function setvalue | test.py:49:12:49:15 | ControlFlowNode for objy | self |
+| test.py:51:1:51:8 | func() | test.py:28:5:28:30 | Function setvalue | test.py:51:6:51:7 | ControlFlowNode for IntegerLiteral | position 0 |
+| test.py:70:1:70:8 | func() | test.py:58:5:58:33 | Function foo | test.py:63:12:63:12 | ControlFlowNode for a | self |
+| test.py:70:1:70:8 | func() | test.py:58:5:58:33 | Function foo | test.py:70:6:70:7 | ControlFlowNode for IntegerLiteral | position 0 |
+| test.py:70:1:70:8 | func() | test.py:58:5:58:33 | Function foo | test.py:70:6:70:7 | ControlFlowNode for IntegerLiteral | self |

python/ql/test/library-tests/dataflow/callgraph_crosstalk/Arguments.ql

@@ -0,0 +1,9 @@
+private import python
+private import semmle.python.dataflow.new.internal.DataFlowPrivate
+private import semmle.python.dataflow.new.internal.DataFlowPublic
+
+from DataFlowCall call, DataFlowCallable callable, ArgumentNode arg, ArgumentPosition apos
+where
+  callable = call.getCallable() and
+  arg = call.getArgument(apos)
+select call, callable, arg, apos

python/ql/test/library-tests/dataflow/callgraph_crosstalk/options

@@ -0,0 +1 @@
+semmle-extractor-options: --max-import-depth=0

python/ql/test/library-tests/dataflow/callgraph_crosstalk/test.py

@@ -0,0 +1,70 @@
+import random
+cond = random.randint(0,1) == 1
+
+# ------------------------------------------------------------------------------
+# Calling different bound-methods based on conditional
+# ------------------------------------------------------------------------------
+
+class CrosstalkTestX:
+    def __init__(self):
+        self.x = None
+        self.y = None
+
+    def setx(self, value):
+        self.x = value
+
+    def setvalue(self, value):
+        self.x = value
+
+
+class CrosstalkTestY:
+    def __init__(self):
+        self.x = None
+        self.y = None
+
+    def sety(self ,value):
+        self.y = value
+
+    def setvalue(self, value):
+        self.y = value
+
+
+objx = CrosstalkTestX()
+objy = CrosstalkTestY()
+
+if cond:
+    func = objx.setx
+else:
+    func = objy.sety
+
+# What we're testing for is whether both objects are passed as self to both methods,
+# which is wrong.
+
+func(42)
+
+
+if cond:
+    func = objx.setvalue
+else:
+    func = objy.setvalue
+
+func(43)
+
+# ------------------------------------------------------------------------------
+# Calling methods in different ways
+# ------------------------------------------------------------------------------
+
+class A(object):
+    def foo(self, arg="Default"):
+        print("A.foo", self, arg)
+
+a = A()
+if cond:
+    func = a.foo # `44` is passed as arg
+else:
+    func = A.foo # `44` is passed as self
+
+# What we're testing for is whether a single call ends up having both `a` and `44` is
+# passed as self to `A.foo`, which is wrong.
+
+func(44)