hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply review comments

Browse Source
This commit is contained in:
Chris Smowton
2021-11-25 15:20:35 +00:00
committed by GitHub
parent db39c0b8be
commit ce63549425
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
java/ql/lib/semmle/code/java/Expr.qll
View File

@@ -713,7 +713,6 @@ class DoubleLiteral extends Literal, @doubleliteral {
override string getAPrimaryQlClass() { result = "DoubleLiteral" }
}
// Implementation taken from @p0 at https://github.com/github/codeql/issues/4145
bindingset[s]
private int fromHex(string s) {
exists(string digits | s.toUpperCase() = digits |
@@ -744,7 +743,7 @@ class CharacterLiteral extends Literal, @characterliteral {
* the character to an `int`.
*/
int getCodePointValue() {
if this.getLiteral().matches("'\\u%'")
if this.getLiteral().matches("'\\u____'")
then result = fromHex(this.getLiteral().substring(3, 7))
else result.toUnicode() = this.getValue()
}