Merge pull request #1867 from geoffw0/erafix9

CPP: Add date to JapaneseEraDate.ql

cpp/ql/test/query-tests/Best Practices/Magic Constants/Japanese Era/ConstructorOrMethodWithExactDate.cpp

@@ -37,4 +37,7 @@ int Main()
 
     // GOOD: method call with the same parameters in a different order (we only track year, month, day)
     EraInfo * pDateTimeUtil4 = EraInfo::EraInfoFromDate(1, 2, 8, 1, 1989, L"\u5e73\u6210");
+
+    // BAD: constructor creating a EraInfo with exact Reiwa era start date
+    EraInfo * pDateTimeUtil5 = new EraInfo(2019, 5, 1);
 }

cpp/ql/test/query-tests/Best Practices/Magic Constants/Japanese Era/JapaneseEraDate.expected

@@ -1,5 +1,7 @@
 | ConstructorOrMethodWithExactDate.cpp:27:31:27:53 | call to EraInfo | Call that appears to have hard-coded Japanese era start date as parameter. |
 | ConstructorOrMethodWithExactDate.cpp:30:32:30:77 | call to EraInfo | Call that appears to have hard-coded Japanese era start date as parameter. |
 | ConstructorOrMethodWithExactDate.cpp:36:32:36:55 | call to EraInfoFromDate | Call that appears to have hard-coded Japanese era start date as parameter. |
+| ConstructorOrMethodWithExactDate.cpp:42:32:42:54 | call to EraInfo | Call that appears to have hard-coded Japanese era start date as parameter. |
 | StructWithExactDate.cpp:31:13:31:19 | tm_year | A time struct that is initialized with exact Japanese calendar era start date. |
 | StructWithExactDate.cpp:46:8:46:12 | wYear | A time struct that is initialized with exact Japanese calendar era start date. |
+| StructWithExactDate.cpp:60:9:60:13 | wYear | A time struct that is initialized with exact Japanese calendar era start date. |

cpp/ql/test/query-tests/Best Practices/Magic Constants/Japanese Era/StructWithExactDate.cpp

@@ -52,6 +52,13 @@ int main()
     st1.wMonth = 1;
     st1.wYear = 1990;
 
+
+    // BAD: Creation of SYSTEMTIME stuct corresponding to the beginning of Reiwa era
+    SYSTEMTIME st2;
+    st2.wDay = 1;
+    st2.wMonth = 5;
+    st2.wYear = 2019;
+
     return 0;
 }