From cd688367c7d5236229224f2faae3c6aa2006c6be Mon Sep 17 00:00:00 2001
From: alexet <alexet@semmle.com>
Date: Thu, 30 Jan 2020 18:49:42 +0000
Subject: [PATCH] CPP: Avoid uncessary recursion

---
 cpp/ql/src/semmle/code/cpp/commons/Printf.qll | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/cpp/ql/src/semmle/code/cpp/commons/Printf.qll b/cpp/ql/src/semmle/code/cpp/commons/Printf.qll
index 8c041351fd0..32cea249214 100644
--- a/cpp/ql/src/semmle/code/cpp/commons/Printf.qll
+++ b/cpp/ql/src/semmle/code/cpp/commons/Printf.qll
@@ -258,14 +258,7 @@ class FormatLiteral extends Literal {
    * Gets the position in the string at which the nth conversion specifier
    * starts.
    */
-  int getConvSpecOffset(int n) {
-    n = 0 and result = this.getFormat().indexOf("%", 0, 0)
-    or
-    n > 0 and
-    exists(int p |
-      n = p + 1 and result = this.getFormat().indexOf("%", 0, this.getConvSpecOffset(p) + 2)
-    )
-  }
+  int getConvSpecOffset(int n) { result = this.getFormat().indexOf("%", n, 0) }
 
   /*
    * Each of these predicates gets a regular expressions to match each individual