From 22029410f0f6818a2ed2fff197eefe5bc20e2b7e Mon Sep 17 00:00:00 2001 From: Sauyon Lee Date: Mon, 28 Oct 2019 15:16:19 -0700 Subject: [PATCH 1/3] Create an action workflow for CodeQL tests --- .github/workflows/codeqltest.yml | 70 ++++++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+) create mode 100644 .github/workflows/codeqltest.yml diff --git a/.github/workflows/codeqltest.yml b/.github/workflows/codeqltest.yml new file mode 100644 index 00000000000..e463867c00e --- /dev/null +++ b/.github/workflows/codeqltest.yml @@ -0,0 +1,70 @@ +name: CodeQL tests +on: [pull_request] +jobs: + + test-linux: + name: Test Linux (Ubuntu) + runs-on: ubuntu-latest + steps: + + - name: Set up Go 1.13.3 + uses: actions/setup-go@v1 + with: + go-version: 1.13.3 + id: go + + - name: Set up CodeQL CLI + uses: Anthophila/codeql-action/setup-codeql@master + + - name: Check out code + uses: actions/checkout@v2 + + - name: Build + run: make + + - name: Test + run: make test + + test-mac: + name: Test MacOS + runs-on: macOS-latest + steps: + - name: Set up Go 1.13.3 + uses: actions/setup-go@v1 + with: + go-version: 1.13.3 + id: go + + - name: Set up CodeQL CLI + uses: Anthophila/codeql-action/setup-codeql@master + + - name: Check out code + uses: actions/checkout@v2 + + - name: Build + run: make + + - name: Test + run: make test + + test-win: + name: Test Windows + runs-on: windows-latest + steps: + - name: Set up Go 1.13.3 + uses: actions/setup-go@v1 + with: + go-version: 1.13.3 + id: go + + - name: Set up CodeQL CLI + uses: Anthophila/codeql-action/setup-codeql@master + + - name: Check out code + uses: actions/checkout@v2 + + - name: Build + run: make + + - name: Test + run: make test From fdb7852cf63a0fbfde2fe054b121478b82e2362f Mon Sep 17 00:00:00 2001 From: Sauyon Lee Date: Wed, 30 Oct 2019 14:20:26 -0700 Subject: [PATCH 2/3] Force git not to mangle line endings for files relevant to tests --- .gitattributes | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .gitattributes diff --git a/.gitattributes b/.gitattributes new file mode 100644 index 00000000000..ae36a7d7a73 --- /dev/null +++ b/.gitattributes @@ -0,0 +1,5 @@ +# Force git not to modify line endings for go files +*.go binary + +# Force git not to modify line endings for dbschemes +*.dbscheme binary From 1365da2224280d95e3afd6c1b4ebc806a0cecce5 Mon Sep 17 00:00:00 2001 From: Sauyon Lee Date: Mon, 10 Feb 2020 13:09:57 -0800 Subject: [PATCH 3/3] examples/variable: Select declaration as well as the variable This makes the test platform-independent --- ql/examples/snippets/variable.ql | 2 +- .../example-tests/snippets/variable.expected | 48 +------------------ 2 files changed, 2 insertions(+), 48 deletions(-) diff --git a/ql/examples/snippets/variable.ql b/ql/examples/snippets/variable.ql index c6587103368..28bb4934544 100644 --- a/ql/examples/snippets/variable.ql +++ b/ql/examples/snippets/variable.ql @@ -10,4 +10,4 @@ import go from Variable err where err.getName() = "err" -select err +select err, err.getDeclaration() diff --git a/ql/test/example-tests/snippets/variable.expected b/ql/test/example-tests/snippets/variable.expected index 8f51749125b..64934db25a0 100644 --- a/ql/test/example-tests/snippets/variable.expected +++ b/ql/test/example-tests/snippets/variable.expected @@ -1,47 +1 @@ -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| file://:0:0:0:0 | err | -| main.go:29:2:29:4 | err | +| main.go:29:2:29:4 | err | main.go:29:2:29:4 | err |