From ca4c988e97bcb2fc3fbdee7aa2f0d7bacfb1da51 Mon Sep 17 00:00:00 2001 From: Owen Mansel-Chan Date: Fri, 13 Feb 2026 22:58:09 +0000 Subject: [PATCH] Remove redundant variable --- .../CWE/CWE-625/PermissiveDotRegexQuery.qll | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/java/ql/src/experimental/Security/CWE/CWE-625/PermissiveDotRegexQuery.qll b/java/ql/src/experimental/Security/CWE/CWE-625/PermissiveDotRegexQuery.qll index 027e4f931cb..2c372d1778c 100644 --- a/java/ql/src/experimental/Security/CWE/CWE-625/PermissiveDotRegexQuery.qll +++ b/java/ql/src/experimental/Security/CWE/CWE-625/PermissiveDotRegexQuery.qll @@ -77,17 +77,12 @@ private class SpringUriInputParameterSource extends DataFlow::Node { */ private class CompileRegexSink extends DataFlow::ExprNode { CompileRegexSink() { - exists(MethodCall ma, Method m | m = ma.getMethod() | - ( - ma.getArgument(0) = this.asExpr() and - ( - ma instanceof StringMatchesCall // input.matches(regexPattern) - or - ma instanceof PatternCompileCall // p = Pattern.compile(regexPattern) - or - ma instanceof PatternMatchesCall // p = Pattern.matches(regexPattern, input) - ) - ) + exists(MethodCall ma | ma.getArgument(0) = this.asExpr() | + ma instanceof StringMatchesCall // input.matches(regexPattern) + or + ma instanceof PatternCompileCall // p = Pattern.compile(regexPattern) + or + ma instanceof PatternMatchesCall // p = Pattern.matches(regexPattern, input) ) } }