hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

Controller is public, non-abstract, not generic class

Browse Source
This commit is contained in:
Octokit
2022-06-03 19:33:39 +03:00
committed by Michael Nebel
parent 853a80bdbc
commit c96b938e7d
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
csharp/ql/lib/semmle/code/csharp/frameworks/microsoft/AspNetCore.qll
View File

@@ -194,7 +194,11 @@ class MicrosoftAspNetCoreMvcControllerBaseClass extends Class {
}
}
/** A valid ASP.NET Core controller according to https://docs.microsoft.com/en-us/aspnet/core/mvc/controllers/actions?view=aspnetcore-3.1 */
/**
* A valid ASP.NET Core controller according to:
* https://docs.microsoft.com/en-us/aspnet/core/mvc/controllers/actions?view=aspnetcore-3.1
* https://github.com/dotnet/aspnetcore/blob/b3c93967ba508b8ef139add27132d9483c1a9eb4/src/Mvc/Mvc.Core/src/Controllers/ControllerFeatureProvider.cs#L39-L75
*/
class MicrosoftAspNetCoreMvcController extends Class {
MicrosoftAspNetCoreMvcController() {
exists(Assembly a, string name |
@@ -204,6 +208,9 @@ class MicrosoftAspNetCoreMvcController extends Class {
name = "Microsoft.AspNetCore.Mvc.ViewFeatures"
)
) and
this.isPublic() and
not this.isAbstract() and
not this.containsTypeParameters() and
(
this.getABaseType*() instanceof MicrosoftAspNetCoreMvcControllerBaseClass or
this.getABaseType*().getName().matches("%Controller") or