hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-18 01:33:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: Minor adjustments to XPath Injection

Browse Source
This commit is contained in:
Rasmus Wriedt Larsen
2021-09-24 15:02:39 +02:00
parent 289660067c
commit c9640ffdbc
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
python/ql/src/experimental/Security/CWE-643-new/Xpath.ql → python/ql/src/experimental/Security/CWE-643-new/XpathInjection.ql
View File

@@ -18,6 +18,7 @@ private import semmle.python.ApiGraphs
private import semmle.python.dataflow.new.RemoteFlowSources
private import semmle.python.dataflow.new.BarrierGuards
import XpathInjection::XpathInjection
import DataFlow::PathGraph
class XpathInjectionConfiguration extends TaintTracking::Configuration {
XpathInjectionConfiguration() { this = "PathNotNormalizedConfiguration" }
@@ -25,12 +26,8 @@ class XpathInjectionConfiguration extends TaintTracking::Configuration {
override predicate isSource(DataFlow::Node source) { source instanceof Source }
override predicate isSink(DataFlow::Node sink) { sink instanceof Sink }
// override predicate isAdditionalTaintStep(DataFlow::Node node1, DataFlow::Node node2) {
// exists(AdditionalFlowStep af | af.isAdditionalTaintStep(node1, node2))
// }
}
from XpathInjectionConfiguration config, DataFlow::PathNode source, DataFlow::PathNode sink
where config.hasFlowPath(source, sink)
select sink, source, sink, "This Xpath query depends on $@.", source,
"a user-provided value"
select sink, source, sink, "This Xpath query depends on $@.", source, "a user-provided value"