mirror of
https://github.com/github/codeql.git
synced 2026-04-30 11:15:13 +02:00
JS: address review comments
This commit is contained in:
@@ -379,7 +379,7 @@ module NodeJSLib {
|
||||
*
|
||||
* We determine this by looking for an externs declaration for
|
||||
* `fs.methodName` where the `i`th parameter's name is `data` or
|
||||
* `buffer` or a 'callback'.
|
||||
* `buffer` or a `callback`.
|
||||
*/
|
||||
private predicate fsDataParam(string methodName, int i, string n) {
|
||||
exists (ExternalMemberDecl decl, Function f, JSDocParamTag p |
|
||||
|
||||
@@ -42,13 +42,8 @@ module FileAccessToHttp {
|
||||
node instanceof Sanitizer
|
||||
}
|
||||
|
||||
/** additional taint step that taints an object wrapping a source */
|
||||
override predicate isAdditionalTaintStep(DataFlow::Node pred, DataFlow::Node succ) {
|
||||
(
|
||||
pred = DataFlow::valueNode(_) or
|
||||
pred = DataFlow::parameterNode(_) or
|
||||
pred instanceof DataFlow::PropRead
|
||||
) and
|
||||
// taint entire object on property write
|
||||
exists (DataFlow::PropWrite pwr |
|
||||
succ = pwr.getBase() and
|
||||
pred = pwr.getRhs()
|
||||
|
||||
Reference in New Issue
Block a user