hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Add UselessConditional test

Browse Source
This commit is contained in:
Asger Feldthaus
2020-05-15 13:33:30 +01:00
parent 192bf918c3
commit c869812563
2 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
javascript/ql/test/query-tests/Statements/UselessConditional/UselessConditional.expected
View File

@@ -29,6 +29,7 @@
| UselessConditional.js:151:6:151:6 | v | This use of variable 'v' always evaluates to true. |
| UselessConditional.js:163:5:163:17 | findOrThrow() | This call to findOrThrow always evaluates to true. |
| UselessConditional.js:166:6:166:6 | v | This use of variable 'v' always evaluates to true. |
| UselessConditional.js:183:17:183:18 | !x | This negation always evaluates to true. |
| UselessConditionalGood.js:58:12:58:13 | x2 | This use of variable 'x2' always evaluates to false. |
| UselessConditionalGood.js:69:12:69:13 | xy | This use of variable 'xy' always evaluates to false. |
| UselessConditionalGood.js:85:12:85:13 | xy | This use of variable 'xy' always evaluates to false. |

14
javascript/ql/test/query-tests/Statements/UselessConditional/UselessConditional.js
View File

@@ -176,3 +176,17 @@ async function awaitFlow(){
if (v) { // OK
}
});
(function() {
function outer(x) {
addEventListener("click", () => {
if (!x && something()) { // NOT OK
something();
}
});
}
function inner() {
outer(); // Omit parameter
}
inner();
});