hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Update python/ql/src/meta/alerts/RemoteFlowSourcesReach.ql

Browse Source 
Co-authored-by: Rasmus Wriedt Larsen <rasmuswl@github.com>
This commit is contained in:
yoff
2021-09-06 16:00:58 +02:00
committed by GitHub
parent 065075056b
commit c7146ac10c
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
python/ql/src/meta/alerts/RemoteFlowSourcesReach.ql
View File

@@ -31,9 +31,17 @@ class RemoteFlowSourceReach extends TaintTracking::Configuration {
or
this.isAdditionalFlowStep(_, node)
) and
// we used to do `obj -> obj.meth` and `obj.meth -> obj.meth()` in two separate
// steps, and now do them in one `obj -> obj.meth()`. So we're going to ignore the
// fact that we no longer taint the node in the middle.
// In september 2021 we changed how we do taint-propagation for method calls (mostly
// relating to modeled frameworks/libraries). We used to do `obj -> obj.meth` and
// `obj.meth -> obj.meth()` in two separate steps, and now do them in one
// `obj -> obj.meth()`. To be able to compare the overall reach between these two
// version, we don't want this query to alert us to the fact that we no longer taint
// the node in the middle (since that is just noise).
// see https://github.com/github/codeql/pull/6349
//
// We should be able to remove the following few lines of code once we don't care to
// compare with the old (before September 2021) way of doing taint-propagation for
// method calls.
not exists(DataFlow::MethodCallNode c |
node = c.getFunction() and
this.isAdditionalFlowStep(c.getObject(), node) and