hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-21 19:26:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

Moved allowBackup query logic to allowsBackup pred

Browse Source
This commit is contained in:
Ed Minnix
2022-09-07 12:08:25 -04:00
parent 5206c792b0
commit c69a2be976
2 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
java/ql/src/Security/CWE/CWE-312/AllowBackupAttributeEnabled.ql
View File

@@ -14,15 +14,5 @@ import java
import semmle.code.xml.AndroidManifest
from AndroidApplicationXmlElement androidAppElem
where
not androidAppElem.getFile().(AndroidManifestXmlFile).isInBuildDirectory() and
(
// explicitly sets android:allowBackup=true
androidAppElem.allowsBackupExplicitly()
or
// Manifest providing the main intent for an application, and does not explicitly
// disallow the allowBackup attribute
androidAppElem.providesMainIntent() and
androidAppElem.allowsBackup()
)
where androidAppElem.allowsBackup()
select androidAppElem, "The 'android:allowBackup' attribute is enabled."