hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-18 01:33:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: avoid selecting getLocation() in py/unnecessary-delete

Browse Source
This commit is contained in:
Nick Rolfe
2023-06-05 10:44:22 +01:00
parent 06d48dca67
commit c67a350e36
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
python/ql/src/Statements/UnnecessaryDelete.ql
View File

@@ -36,5 +36,5 @@ where
ex = Value::named("sys.exc_info") and ex = Value::named("sys.exc_info") and
ex.getACall().getScope() = f ex.getACall().getScope() = f
) )
select del, "Unnecessary deletion of local variable $@ in function $@.", e.getLocation(), select del, "Unnecessary deletion of local variable $@ in function $@.", e, e.toString(), f,
e.toString(), f.getLocation(), f.getName() f.getName()

2
python/ql/test/query-tests/Statements/general/UnnecessaryDelete.expected
View File

@@ -1 +1 @@
| statements_test.py:187:5:187:9 | Delete | Unnecessary deletion of local variable $@ in function $@. | statements_test.py:187:9:187:9 | statements_test.py:187 | x | statements_test.py:185:1:185:31 | statements_test.py:185 | error_unnecessary_delete | | statements_test.py:187:5:187:9 | Delete | Unnecessary deletion of local variable $@ in function $@. | statements_test.py:187:9:187:9 | x | x | statements_test.py:185:1:185:31 | Function error_unnecessary_delete | error_unnecessary_delete |