hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Fix condition in getRouteHandlerNode

Browse Source 
Previous version did not account for arrays
This commit is contained in:
Asger F
2023-04-27 17:56:01 +02:00
parent 682ff23e04
commit c674afb674
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
javascript/ql/lib/semmle/javascript/frameworks/Express.qll
View File

@@ -164,9 +164,9 @@ module Express {
*/
DataFlow::Node getRouteHandlerNode(int index) {
// The first argument is a URI pattern if it is a string. If it could possibly be
// a function, we consider it to be a route handler, otherwise a URI pattern.
// a non-string value, we consider it to be a route handler, otherwise a URI pattern.
exists(AnalyzedNode firstArg | firstArg = this.getArgument(0).analyze() |
if firstArg.getAType() = TTFunction()
if firstArg.getAType() != TTString()
then result = this.getArgument(index)
else (
index >= 0 and result = this.getArgument(index + 1)