hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-22 03:36:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: Fix dataflow consistencies for default parameter values

Browse Source
This commit is contained in:
Rasmus Wriedt Larsen
2023-07-07 11:55:07 +02:00
parent 6f3cb67050
commit c5e8e232e5
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPrivate.qll
View File

@@ -292,7 +292,12 @@ module EssaFlow {
// nodeFrom is `f(42)`, cfg node
// nodeTo is `x`, essa var
nodeFrom.(CfgNode).getNode() =
nodeTo.(EssaNode).getVar().getDefinition().(AssignmentDefinition).getValue()
nodeTo.(EssaNode).getVar().getDefinition().(AssignmentDefinition).getValue() and
// we need to ensure that enclosing callable is the same, since a parameter with a
// default value will be in the scope of the function, while the default value
// itself will be in the scope that _defines_ the function.
// We handle _that_ as a jumpstep
nodeFrom.getEnclosingCallable() = nodeTo.getEnclosingCallable()
or
// With definition
// `with f(42) as x:`
@@ -463,6 +468,13 @@ predicate runtimeJumpStep(Node nodeFrom, Node nodeTo) {
or
// Setting the possible values of the variable at the end of import time
nodeFrom = nodeTo.(ModuleVariableNode).getADefiningWrite()
or
// a parameter with a default value, since the parameter will be in the scope of the
// function, while the default value itself will be in the scope that _defines_ the
// function.
nodeFrom.(CfgNode).getNode() =
nodeTo.(EssaNode).getVar().getDefinition().(AssignmentDefinition).getValue() and
not nodeFrom.getEnclosingCallable() = nodeTo.getEnclosingCallable()
}
/**