hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-04 21:25:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

Rust: Add a flow test for to_string() and parse().

Browse Source
This commit is contained in:
Geoffrey White
2025-02-06 10:29:02 +00:00
parent 6966c96e7a
commit c597818c4b
3 changed files with 49 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
rust/ql/test/library-tests/dataflow/local/DataFlowStep.expected
View File

@@ -495,8 +495,31 @@ localStep
| main.rs:428:9:428:9 | s | main.rs:428:9:428:9 | [SSA] s | |
| main.rs:428:13:428:27 | MacroExpr | main.rs:428:9:428:9 | s | |
| main.rs:428:25:428:26 | source(...) | main.rs:428:13:428:27 | MacroExpr | |
| main.rs:454:13:454:33 | result_questionmark(...) | main.rs:454:9:454:9 | _ | |
| main.rs:466:36:466:41 | ...::new(...) | main.rs:466:36:466:41 | MacroExpr | |
| main.rs:432:16:432:16 | [SSA] s | main.rs:433:20:433:20 | s | |
| main.rs:432:16:432:16 | s | main.rs:432:16:432:16 | [SSA] s | |
| main.rs:432:16:432:24 | ...: String | main.rs:432:16:432:16 | s | |
| main.rs:433:14:433:20 | FormatArgsExpr | main.rs:433:14:433:20 | MacroExpr | |
| main.rs:433:14:433:20 | MacroExpr | main.rs:433:5:433:21 | ...::_print | MaD:1 |
| main.rs:437:9:437:9 | [SSA] a | main.rs:438:13:438:13 | a | |
| main.rs:437:9:437:9 | a | main.rs:437:9:437:9 | [SSA] a | |
| main.rs:437:13:437:22 | source(...) | main.rs:437:9:437:9 | a | |
| main.rs:438:9:438:9 | [SSA] b | main.rs:439:13:439:13 | b | |
| main.rs:438:9:438:9 | b | main.rs:438:9:438:9 | [SSA] b | |
| main.rs:438:13:438:13 | [post] a | main.rs:442:10:442:10 | a | |
| main.rs:438:13:438:13 | a | main.rs:442:10:442:10 | a | |
| main.rs:438:13:438:25 | a.to_string(...) | main.rs:438:9:438:9 | b | |
| main.rs:439:9:439:9 | [SSA] c | main.rs:444:10:444:10 | c | |
| main.rs:439:9:439:9 | c | main.rs:439:9:439:9 | [SSA] c | |
| main.rs:439:13:439:13 | [post] b | main.rs:440:19:440:19 | b | |
| main.rs:439:13:439:13 | b | main.rs:440:19:440:19 | b | |
| main.rs:439:13:439:37 | ... .unwrap(...) | main.rs:439:9:439:9 | c | |
| main.rs:440:9:440:9 | [SSA] d | main.rs:445:10:445:10 | d | |
| main.rs:440:9:440:9 | d | main.rs:440:9:440:9 | [SSA] d | |
| main.rs:440:19:440:19 | [post] b | main.rs:443:17:443:17 | b | |
| main.rs:440:19:440:19 | b | main.rs:443:17:443:17 | b | |
| main.rs:440:19:440:36 | ... .unwrap(...) | main.rs:440:9:440:9 | d | |
| main.rs:470:13:470:33 | result_questionmark(...) | main.rs:470:9:470:9 | _ | |
| main.rs:482:36:482:41 | ...::new(...) | main.rs:482:36:482:41 | MacroExpr | |
models
| 1 | Sink: lang:std; crate::io::stdio::_print; log-injection; Argument[0] |
| 2 | Summary: lang:core; <crate::option::Option>::expect; Argument[self].Variant[crate::option::Option::Some(0)]; ReturnValue; value |
@@ -601,7 +624,7 @@ storeStep
| main.rs:399:30:399:30 | 3 | element | main.rs:399:23:399:31 | [...] |
| main.rs:402:18:402:27 | source(...) | element | main.rs:402:5:402:11 | [post] mut_arr |
| main.rs:414:41:414:67 | default_name | captured default_name | main.rs:414:41:414:67 | \|...\| ... |
| main.rs:436:27:436:27 | 0 | Some | main.rs:436:22:436:28 | Some(...) |
| main.rs:452:27:452:27 | 0 | Some | main.rs:452:22:452:28 | Some(...) |
readStep
| file://:0:0:0:0 | [summary param] 0 in lang:core::_::<crate::option::Option>::unwrap_or_else | function return | file://:0:0:0:0 | [summary] read: Argument[0].ReturnValue in lang:core::_::<crate::option::Option>::unwrap_or_else |
| file://:0:0:0:0 | [summary param] 0 in lang:core::_::<crate::result::Result>::unwrap_or_else | function return | file://:0:0:0:0 | [summary] read: Argument[0].ReturnValue in lang:core::_::<crate::result::Result>::unwrap_or_else |

6
rust/ql/test/library-tests/dataflow/local/inline-flow.expected
View File

@@ -179,6 +179,8 @@ edges
| main.rs:405:10:405:16 | mut_arr [element] | main.rs:405:10:405:19 | mut_arr[0] | provenance | |
| main.rs:428:9:428:9 | s | main.rs:429:10:429:10 | s | provenance | |
| main.rs:428:25:428:26 | source(...) | main.rs:428:9:428:9 | s | provenance | |
| main.rs:437:9:437:9 | a | main.rs:442:10:442:10 | a | provenance | |
| main.rs:437:13:437:22 | source(...) | main.rs:437:9:437:9 | a | provenance | |
nodes
| main.rs:15:10:15:18 | source(...) | semmle.label | source(...) |
| main.rs:19:9:19:9 | s | semmle.label | s |
@@ -386,6 +388,9 @@ nodes
| main.rs:428:9:428:9 | s | semmle.label | s |
| main.rs:428:25:428:26 | source(...) | semmle.label | source(...) |
| main.rs:429:10:429:10 | s | semmle.label | s |
| main.rs:437:9:437:9 | a | semmle.label | a |
| main.rs:437:13:437:22 | source(...) | semmle.label | source(...) |
| main.rs:442:10:442:10 | a | semmle.label | a |
subpaths
testFailures
#select
@@ -430,3 +435,4 @@ testFailures
| main.rs:404:10:404:10 | d | main.rs:402:18:402:27 | source(...) | main.rs:404:10:404:10 | d | $@ | main.rs:402:18:402:27 | source(...) | source(...) |
| main.rs:405:10:405:19 | mut_arr[0] | main.rs:402:18:402:27 | source(...) | main.rs:405:10:405:19 | mut_arr[0] | $@ | main.rs:402:18:402:27 | source(...) | source(...) |
| main.rs:429:10:429:10 | s | main.rs:428:25:428:26 | source(...) | main.rs:429:10:429:10 | s | $@ | main.rs:428:25:428:26 | source(...) | source(...) |
| main.rs:442:10:442:10 | a | main.rs:437:13:437:22 | source(...) | main.rs:442:10:442:10 | a | $@ | main.rs:437:13:437:22 | source(...) | source(...) |

17
rust/ql/test/library-tests/dataflow/local/main.rs
View File

@@ -429,6 +429,22 @@ fn macro_invocation() {
sink(s); // $ hasValueFlow=37
}
fn sink_string(s: String) {
println!("{}", s);
}
fn parse() {
let a = source(90);
let b = a.to_string();
let c = b.parse::<i64>().unwrap();
let d : i64 = b.parse().unwrap();
sink(a); // $ hasValueFlow=90
sink_string(b); // $ MISSING: hasTaintFlow=90
sink(c); // $ MISSING: hasTaintFlow=90
sink(d); // $ MISSING: hasTaintFlow=90
}
fn main() {
direct();
variable_usage();
@@ -465,4 +481,5 @@ fn main() {
array_assignment();
captured_variable_and_continue(vec![]);
macro_invocation();
parse();
}