From c50bcbacc06b937b38dfb56d92593449158dc514 Mon Sep 17 00:00:00 2001
From: Taus <tausbn@github.com>
Date: Thu, 23 Jul 2026 14:03:43 +0000
Subject: [PATCH] swift-syntax-rs: Degrade gracefully without a Swift toolchain
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

`swift-syntax-rs` is a workspace member, so its build script runs on a
plain `cargo check`/`fmt`/`clippy` at the repo root. Previously it
panicked when `swift build` could not be run, breaking those Swift-free
workflows for anyone without a Swift toolchain.

Instead, when `swift build` cannot be spawned, emit a `cargo:warning`
and skip the link directives rather than panicking. `cargo
check`/`fmt`/`clippy` don't link, so they keep working; only `cargo
build`/`cargo test` then fail, at link time — which is fair, since those
genuinely need Swift (and CI builds go through Bazel). A Swift toolchain
that is present but whose build fails is still surfaced as a hard error.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 unified/swift-syntax-rs/build.rs | 32 +++++++++++++++++++++++---------
 1 file changed, 23 insertions(+), 9 deletions(-)

diff --git a/unified/swift-syntax-rs/build.rs b/unified/swift-syntax-rs/build.rs
index c599cdf4e70..6a58ddb4d8d 100644
--- a/unified/swift-syntax-rs/build.rs
+++ b/unified/swift-syntax-rs/build.rs
@@ -24,20 +24,34 @@ fn main() {
     println!("cargo:rerun-if-env-changed=SWIFTC");
 
     // Build the Swift FFI package as a release dynamic library.
+    //
+    // Degrade gracefully when there is no runnable Swift toolchain. This crate
+    // is a workspace member, so a plain `cargo check`/`fmt`/`clippy` at the repo
+    // root runs this build script; if `swift build` cannot even be spawned we
+    // emit a warning and skip the link directives rather than panicking, so
+    // those Swift-free workflows keep working. Only `cargo build`/`cargo test`
+    // then fail — at link time, which is fair: they genuinely need Swift (and CI
+    // builds go through Bazel anyway). A Swift toolchain that *is* present but
+    // whose build fails is still surfaced as a hard error below.
     let mut command = Command::new(swift_bin());
     command
         .args(["build", "-c", "release"])
         .current_dir(&swift_dir);
     apply_bare_repository_workaround(&mut command);
-    let status = command.status().unwrap_or_else(|e| {
-        panic!(
-            "failed to run `{swift} build`: {e}\n\
-             Install a Swift toolchain (see https://www.swift.org/install/, e.g. via \
-             swiftly) and ensure `swift` is on PATH, or set the `SWIFT` environment \
-             variable to the `swift` executable. The pinned version is in `.swift-version`.",
-            swift = swift_bin(),
-        )
-    });
+    let status = match command.status() {
+        Ok(status) => status,
+        Err(e) => {
+            println!(
+                "cargo:warning=skipping the Swift FFI build: failed to run `{swift} build`: {e}. \
+                 Install a Swift toolchain (see https://www.swift.org/install/, e.g. via swiftly) \
+                 and ensure `swift` is on PATH, or set the `SWIFT` environment variable, to build \
+                 or test this crate. `cargo check`/`fmt`/`clippy` work without it. The pinned \
+                 version is in `.swift-version`.",
+                swift = swift_bin(),
+            );
+            return;
+        }
+    };
     assert!(status.success(), "`swift build` failed");
 
     // Link against the freshly built dynamic library.