hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 09:15:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Fix handling of unknown properties

Browse Source 
These would shorten the expected distance to a node, but would never be usable as an edge, meaning we failed to pick a preferred predecessor.
This commit is contained in:
Asger F
2024-02-14 14:10:34 +01:00
parent 3ff950660b
commit c4a0f36a08
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javascript/ql/lib/semmle/javascript/endpoints/EndpointNaming.qll
View File

@@ -39,7 +39,7 @@ private string join(string x, string y) {
private predicate isPackageExport(API::Node node) { node = API::moduleExport(_) }
private predicate relevantEdge(API::Node pred, API::Node succ) {
succ = pred.getAMember() and
succ = pred.getMember(_) and
not isPrivateLike(succ)
}

1
javascript/ql/test/library-tests/EndpointNaming/EndpointNaming.expected
View File

@@ -2,7 +2,6 @@ testFailures
| pack11/index.ts:33:1:33:16 | | Unexpected result: method=(pack11).C3.privateField |
| pack11/index.ts:33:18:33:69 | // $ me ... ng.name | Missing result:method=(pack11).C3.publicField.really.long.name |
| pack11/index.ts:41:23:41:24 | | Unexpected result: alias=(pack11).C3.publicField.really.long.name==(pack11).C3.privateField |
| pack11/index.ts:49:12:49:53 | // $ me ... .name.m | Missing result:method=(pack11).C4.really.long.name.m |
ambiguousPreferredPredecessor
| pack2/lib.js:8:22:8:34 | def moduleImport("pack2").getMember("exports").getMember("lib").getMember("LibClass").getMember("foo") |
ambiguousSinkName