hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 17:25:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Kotlin: Fix handling of non-true conditions

Browse Source
This commit is contained in:
Ian Lynagh
2021-10-28 11:53:13 +01:00
parent b9d6712371
commit c4880cc935
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
java/ql/lib/semmle/code/java/ControlFlowGraph.qll
View File

@@ -930,9 +930,12 @@ private module ControlFlowGraphImpl {
or
exists(WhenBranch whenbranch | whenbranch = n |
// If the condition completes with anything other than true
// (e.g. false or an exception), then the branch is done
// (or "normal", which we will also see if we don't know how
// to make specific true/false edges for the condition)
// (e.g. false or an exception), then the branch is done.
last(whenbranch.getCondition(), last, completion) and
completion != BooleanCompletion(true, _)
not completion = BooleanCompletion(true, _) and
not completion = NormalCompletion()
or
// Otherwise we wrap the completion up in a YieldCompletion
// so that the `when` expression can tell that we have finished,