hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 03:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: Adjust ImpossibleJavadocThrows.ql

Browse Source
This commit is contained in:
Marcono1234
2022-09-26 12:08:43 +02:00
parent fd99ae78b3
commit c40b6285a2
3 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
java/ql/src/Advisory/Documentation/ImpossibleJavadocThrows.ql
View File

@@ -11,7 +11,7 @@
import java
Class getTaggedType(ThrowsTag tag) {
ClassOrInterface getTaggedType(ThrowsTag tag) {
result.hasName(tag.getExceptionName()) and
result = tag.getFile().(CompilationUnit).getATypeInScope()
}
@@ -22,7 +22,9 @@ predicate canThrow(Callable callable, Class exception) {
callable.getAnException().getType().getADescendant() = exception
}
from ThrowsTag throwsTag, Class thrownType, Callable docMethod
// Uses ClassOrInterface as type for thrownType to also cover case where erroneously an interface
// type is declared as thrown exception
from ThrowsTag throwsTag, ClassOrInterface thrownType, Callable docMethod
where
getTaggedType(throwsTag) = thrownType and
docMethod.getDoc().getJavadoc().getAChild*() = throwsTag and