hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-22 03:36:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: Fix problems with missing TAttributeContent

Browse Source
This commit is contained in:
Rasmus Wriedt Larsen
2023-11-13 10:46:40 +01:00
parent 943b2a2ed1
commit c3fa3f26a7
3 changed files with 1 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
python/ql/lib/semmle/python/dataflow/new/internal/DataFlowPublic.qll
View File

@@ -614,7 +614,7 @@ newtype TContent =
// instead we use a qltest to alert if we write a new summary in QL that uses an // instead we use a qltest to alert if we write a new summary in QL that uses an
// attribute -- see // attribute -- see
// python/ql/test/experimental/dataflow/summaries-checks/missing-attribute-content.ql // python/ql/test/experimental/dataflow/summaries-checks/missing-attribute-content.ql
none() // to be filled out in next commit attr in ["re", "string", "pattern"]
or or
// //
// 2) summaries in data-extension files // 2) summaries in data-extension files

12
python/ql/test/experimental/dataflow/summaries-checks/invalid-spec.expected
View File

@@ -1,14 +1,2 @@
| compiled re.Match | Argument[self].Attribute[pattern] | Attribute[pattern] |
| compiled re.Match | ReturnValue.Attribute[re].Attribute[pattern] | Attribute[pattern] |
| compiled re.Match | ReturnValue.Attribute[re].Attribute[pattern] | Attribute[re] |
| compiled re.Match | ReturnValue.Attribute[string] | Attribute[string] |
| compiled re.subn | ReturnValue.TupleElement[0] | TupleElement[0] | | compiled re.subn | ReturnValue.TupleElement[0] | TupleElement[0] |
| re.Match | ReturnValue.Attribute[re].Attribute[pattern] | Attribute[pattern] |
| re.Match | ReturnValue.Attribute[re].Attribute[pattern] | Attribute[re] |
| re.Match | ReturnValue.Attribute[string] | Attribute[string] |
| re.Match.expand | Argument[self].Attribute[string] | Attribute[string] |
| re.Match.group | Argument[self].Attribute[string] | Attribute[string] |
| re.Match.groupdict | Argument[self].Attribute[string] | Attribute[string] |
| re.Match.groups | Argument[self].Attribute[string] | Attribute[string] |
| re.Pattern | ReturnValue.Attribute[pattern] | Attribute[pattern] |
| re.subn | ReturnValue.TupleElement[0] | TupleElement[0] | | re.subn | ReturnValue.TupleElement[0] | TupleElement[0] |

3
python/ql/test/experimental/dataflow/summaries-checks/missing-attribute-content.expected
View File

@@ -1,3 +0,0 @@
| The attribute "pattern" is not a valid TAttributeContent, please add it to the hardcoded list of TAttributeContent in the dataflow library. |
| The attribute "re" is not a valid TAttributeContent, please add it to the hardcoded list of TAttributeContent in the dataflow library. |
| The attribute "string" is not a valid TAttributeContent, please add it to the hardcoded list of TAttributeContent in the dataflow library. |