hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-03 20:58:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com>
This commit is contained in:
ihsinme
2021-10-28 10:17:13 +03:00
committed by GitHub
parent 5d5d6bcc69
commit c3b1d7e5c8
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
cpp/ql/src/experimental/Security/CWE/CWE-243/IncorrectChangingWorkingDirectory.ql
View File

@@ -13,7 +13,7 @@
import cpp
/** Holds if a `fc` function call is available before or before a `chdir` function call. */
/** Holds if a `fc` function call is available before or after a `chdir` function call. */
predicate inExistsChdir(FunctionCall fcp) {
exists(FunctionCall fctmp |
(
@@ -54,7 +54,7 @@ where
not inExistsChdir(fctmp) and
not outExistsChdir(fctmp)
) and
msg = "Creation of chroot Jail Without Changing Working Directory out"
msg = "Creation of 'chroot' jail without changing the working directory"
or
(
fc.getTarget().hasGlobalOrStdName("chdir") or
@@ -65,6 +65,6 @@ where
not exists(ReturnStmt rttmp | rttmp.getExpr().getAChild*() = fc) and
not exists(Assignment astmp | astmp.getAChild*() = fc) and
not exists(Initializer ittmp | ittmp.getExpr().getAChild*() = fc) and
not fc.isInMacroExpansion() and
msg = fc.getTarget().getName() + " unchecked return value."
not isFromMacroDefinition(fc)
msg = "Unchecked return value for call to '" + fc.getTarget().getName() + "'."
select fc, msg