hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 17:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix bad join

Browse Source
This commit is contained in:
Tom Hvitved
2023-02-20 12:02:49 +01:00
committed by Harry Maclean
parent 9880952e72
commit c3679d0661
1 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
ruby/ql/lib/codeql/ruby/frameworks/actioncontroller/Filters.qll
View File

@@ -35,6 +35,17 @@ module Filters {
}
}
bindingset[call]
pragma[inline_late]
private ActionControllerActionMethod getADescendentAction(MethodCallCfgNode call) {
result = call.getExpr().getEnclosingModule().getAMethod()
or
exists(ModuleBase m |
m.getModule() = call.getExpr().getEnclosingModule().getModule().getAnImmediateDescendent+() and
result = m.getAMethod()
)
}
/**
* A call to a class method that adds or removes a filter from the callback chain.
* This class exists to encapsulate common behavior between calls that
@@ -65,14 +76,7 @@ module Filters {
not exists(this.getOnlyArgument()) and
forall(string except | except = this.getExceptArgument() | result.getName() != except)
) and
(
result = this.getExpr().getEnclosingModule().getAMethod()
or
exists(ModuleBase m |
m.getModule() = this.getExpr().getEnclosingModule().getModule().getADescendent() and
result = m.getAMethod()
)
)
result = getADescendentAction(this)
}
private string getOnlyArgument() {