hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 08:45:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Java: Fix CompileTimeConstantExpr qldoc and add char cast case.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2020-06-10 10:59:10 +02:00
parent 06066f0c5b
commit c334d72f11
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
java/ql/src/semmle/code/java/Expr.qll
View File

@@ -305,10 +305,6 @@ class CompileTimeConstantExpr extends Expr {
/**
* Gets the integer value of this expression, where possible.
*
* All computations are performed on QL 32-bit `int`s, so no
* truncation is performed in the case of overflow within `byte` or `short`:
* `((byte)127)+((byte)1)` evaluates to 128 rather than to -128.
*
* Note that this does not handle the following cases:
*
* - values of type `long`,
@@ -332,7 +328,10 @@ class CompileTimeConstantExpr extends Expr {
else
if cast.getType().hasName("short")
then result = (val + 32768).bitAnd(65535) - 32768
else result = val
else
if cast.getType().hasName("char")
then result = val.bitAnd(65535)
else result = val
)
or
result = this.(PlusExpr).getExpr().(CompileTimeConstantExpr).getIntValue()