hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 09:13:20 +01:00
Code Issues Packages Projects Releases Wiki Activity

Python: ObjectAPI to ValueAPI: OverlyComplexDelMethod: Adds preliminary modernization

Browse Source
This commit is contained in:
Rebecca Valentine
2020-04-07 21:31:35 -07:00
parent a0992aac93
commit c2443f2342
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
python/ql/src/Functions/OverlyComplexDelMethod.ql
View File

@@ -15,10 +15,10 @@
import python import python
from FunctionObject method from FunctionValue method
where where
exists(ClassObject c | exists(ClassValue c |
c.declaredAttribute("__del__") = method and c.declaredAttribute("__del__") = method and
method.getFunction().getMetrics().getCyclomaticComplexity() > 3 method.getScope().getMetrics().getCyclomaticComplexity() > 3
) )
select method, "Overly complex '__del__' method." select method, "Overly complex '__del__' method."

2
python/ql/test/query-tests/Functions/general/OverlyComplexDelMethod.expected
View File

@@ -1 +1 @@
| protocols.py:74:5:74:22 | Function __del__ | Overly complex '__del__' method. | | protocols.py:74:5:74:22 | Function MegaDel.__del__ | Overly complex '__del__' method. |