From c243e0313391d3aad3250f6274802ace9e6e8649 Mon Sep 17 00:00:00 2001 From: Chris Smowton Date: Wed, 17 Feb 2021 09:50:56 +0000 Subject: [PATCH] Lang3 StrBuilder: fix typo and coding style --- java/ql/src/semmle/code/java/frameworks/apache/Lang.qll | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/java/ql/src/semmle/code/java/frameworks/apache/Lang.qll b/java/ql/src/semmle/code/java/frameworks/apache/Lang.qll index cd80b44da05..142e1c2d4f2 100644 --- a/java/ql/src/semmle/code/java/frameworks/apache/Lang.qll +++ b/java/ql/src/semmle/code/java/frameworks/apache/Lang.qll @@ -144,7 +144,7 @@ private class ApacheStrBuilderTaintingMethod extends ApacheStrBuilderMethod, Tai } private predicate consumesTaintFromAllArgs() { - // Specifically the append[ln](String, Object...) overloads also consume taint from its other arguments: + // Specifically the append[ln](String, Object...) overloads also consume taint from their other arguments: this.getName() in ["appendAll", "appendWithSeparators"] or this.getName() = ["append", "appendln"] and this.getAParameter().isVarargs() @@ -167,7 +167,7 @@ private class ApacheStrBuilderTaintingMethod extends ApacheStrBuilderMethod, Tai else fromArg = 1 ) or - consumesTaintFromAllArgs() and fromArg in [0 .. this.getNumberOfParameters() - 1] + this.consumesTaintFromAllArgs() and fromArg in [0 .. this.getNumberOfParameters() - 1] ) } }