hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-22 11:46:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: Fold predicate sameLocation

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2020-01-16 16:14:55 +01:00
parent 04ef4d102d
commit c1fcf78f16
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
cpp/ql/src/Likely Bugs/Underspecified Functions/ImplicitFunctionDeclaration.ql
View File

@@ -17,10 +17,17 @@ import TooFewArguments
import TooManyArguments
import semmle.code.cpp.commons.Exclusions
predicate sameLocation(Location loc1, Location loc2) {
loc1.getFile() = loc2.getFile() and
loc1.getStartLine() = loc2.getStartLine() and
loc1.getStartColumn() = loc2.getStartColumn()
predicate locInfo(Locatable e, File file, int line, int col) {
e.getFile() = file and
e.getLocation().getStartLine() = line and
e.getLocation().getStartColumn() = col
}
predicate sameLocation(FunctionDeclarationEntry fde, FunctionCall fc) {
exists(File file, int line, int col |
locInfo(fde, file, line, col) and
locInfo(fc, file, line, col)
)
}
predicate isCompiledAsC(File f) {
@@ -34,7 +41,7 @@ where
isCompiledAsC(fdeIm.getFile()) and
not isFromMacroDefinition(fc) and
fdeIm.isImplicit() and
sameLocation(fdeIm.getLocation(), fc.getLocation()) and
sameLocation(fdeIm, fc) and
not mistypedFunctionArguments(fc, _, _) and
not tooFewArguments(fc, _) and
not tooManyArguments(fc, _)