From c160a1f6581c968a14371ddbdf5df1fe1a98d4c0 Mon Sep 17 00:00:00 2001 From: Geoffrey White <40627776+geoffw0@users.noreply.github.com> Date: Wed, 10 Dec 2025 15:55:28 +0000 Subject: [PATCH] Rust: Fix common FPs for rust/unused-variable and rust/unused-value. --- rust/ql/src/queries/unusedentities/UnusedVariable.qll | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/rust/ql/src/queries/unusedentities/UnusedVariable.qll b/rust/ql/src/queries/unusedentities/UnusedVariable.qll index c0684636e77..64d49a547f1 100644 --- a/rust/ql/src/queries/unusedentities/UnusedVariable.qll +++ b/rust/ql/src/queries/unusedentities/UnusedVariable.qll @@ -43,4 +43,8 @@ predicate isAllowableUnused(Variable v) { or // a 'self' variable v.getText() = "self" + or + // a common source of false positives is match arms that are misrecognized as + // a variable, having not been correctly resolved + v.getPat().getParentNode() instanceof MatchArm }