hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 01:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: No need to select the 'instruction' as the sink when the dataflow node has a better 'toString'.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2023-07-13 14:17:43 +01:00
parent 5e06043120
commit c13f015b95
2 changed files with 34 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cpp/ql/src/experimental/Security/CWE/CWE-193/InvalidPointerDeref.ql
View File

@@ -540,6 +540,6 @@ where
offset = pai.getRight().getUnconvertedResultExpression() and
n = source.getNode() and
if k = 0 then kstr = "" else kstr = " + " + k
select sink.getNode().asInstruction(), source, sink,
select sink.getNode(), source, sink,
"This " + operation + " might be out of bounds, as the pointer might be equal to $@ + $@" + kstr +
".", n, n.toString(), offset, offset.toString()