hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

made the blacklist for methods named "function" work again

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2019-10-02 14:56:41 +02:00
parent e5290f3bb0
commit c0b7538cf0
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javascript/ql/src/Declarations/SuspiciousMethodNameDeclaration.ql
View File

@@ -52,7 +52,7 @@ where
// The developer was not confused about "function" when there are other methods in the interface.
name = "function" and
exists(MethodDeclaration other | other = container.getAMethod() |
name != "function" and
other.getName() != "function" and
not other.(ConstructorDeclaration).isSynthetic()
)
)

1
javascript/ql/test/query-tests/Declarations/SuspiciousMethodNameDeclaration/SuspiciousMethodNameDeclaration.expected
View File

@@ -1,4 +1,3 @@
| tst.ts:4:3:4:22 | function (): number; | The member name 'function' does not declare a function, it declares a method named 'function'. |
| tst.ts:7:3:7:24 | constru ... string; | The member name 'constructor' does not declare a constructor in interface declarations, but it does in class declarations. |
| tst.ts:16:3:16:21 | function(): number; | The member name 'function' does not declare a function, it declares a method named 'function'. |
| tst.ts:37:3:37:21 | function(): number; | The member name 'function' does not declare a function, it declares a method named 'function'. |