hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-20 08:53:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

AST: rename getLhs/getRhs to getLeftOperand/getRightOperand

Browse Source
This commit is contained in:
Arthur Baars
2021-02-18 13:25:03 +01:00
parent 095eb803b3
commit c0b5ac760a
5 changed files with 18 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ql/src/codeql_ruby/ast/Operation.qll
View File

@@ -445,10 +445,10 @@ class Assignment extends Operation {
override Assignment::Range range;
/** Gets the left hand side of this assignment. */
final Expr getLhs() { result = range.getLhs() }
final Expr getLeftOperand() { result = range.getLeftOperand() }
/** Gets the right hand side of this assignment. */
final Expr getRhs() { result = range.getRhs() }
final Expr getRightOperand() { result = range.getRightOperand() }
}
/**

2
ql/src/codeql_ruby/ast/Variable.qll
View File

@@ -156,7 +156,7 @@ class VariableReadAccess extends VariableAccess {
not this instanceof VariableWriteAccess
or
// `x` in `x += y` is considered both a read and a write
this = any(AssignOperation a).getLhs()
this = any(AssignOperation a).getLeftOperand()
}
}

16
ql/src/codeql_ruby/ast/internal/Operation.qll
View File

@@ -218,11 +218,13 @@ module NoRegexMatchExpr {
module Assignment {
abstract class Range extends Operation::Range {
abstract Expr getLhs();
abstract Pattern getLeftOperand();
abstract Expr getRhs();
abstract Expr getRightOperand();
final override Expr getAnOperand() { result = this.getLhs() or result = this.getRhs() }
final override Expr getAnOperand() {
result = this.getLeftOperand() or result = this.getRightOperand()
}
override string toString() { result = "... " + this.getOperator() + " ..." }
}
@@ -232,9 +234,9 @@ module AssignExpr {
class Range extends Assignment::Range, @assignment {
final override Generated::Assignment generated;
final override Expr getLhs() { result = generated.getLeft() }
final override Pattern getLeftOperand() { result = generated.getLeft() }
final override Expr getRhs() { result = generated.getRight() }
final override Expr getRightOperand() { result = generated.getRight() }
final override string getOperator() { result = "=" }
}
@@ -246,9 +248,9 @@ module AssignOperation {
final override string getOperator() { result = generated.getOperator() }
final override LhsExpr getLhs() { result = generated.getLeft() }
final override LhsExpr getLeftOperand() { result = generated.getLeft() }
final override Expr getRhs() { result = generated.getRight() }
final override Expr getRightOperand() { result = generated.getRight() }
}
}

4
ql/src/codeql_ruby/controlflow/CfgNodes.qll
View File

@@ -218,10 +218,10 @@ module ExprNodes {
final override Assignment getExpr() { result = ExprCfgNode.super.getExpr() }
/** Gets the LHS of this assignment. */
final ExprCfgNode getLhs() { e.hasCfgChild(e.getLhs(), this, result) }
final ExprCfgNode getLhs() { e.hasCfgChild(e.getLeftOperand(), this, result) }
/** Gets the RHS of this assignment. */
final ExprCfgNode getRhs() { e.hasCfgChild(e.getRhs(), this, result) }
final ExprCfgNode getRhs() { e.hasCfgChild(e.getRightOperand(), this, result) }
}
/** A control-flow node that wraps an `AssignExpr` AST expression. */