hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-02 04:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

C++: Improve performance of ExprEvaluator::getFunctionValue.

Browse Source 
Changes the `forex` range to join on both `this` (the current `ExprEvaluator`) and `ret` (the expected function return value),
so that we look at the relevant return values rather than all interesting functions.
This commit is contained in:
Aditya Sharad
2018-11-05 16:43:35 +00:00
parent 19f238a51a
commit bfa4c30784
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
cpp/ql/src/semmle/code/cpp/controlflow/internal/ConstantExprs.qll
View File

@@ -419,12 +419,17 @@ library class ExprEvaluator extends int {
)
}
/** Holds if the function `f` is considered by the analysis and may return `ret`. */
pragma[noinline]
private predicate interestingReturnValue(Function f, Expr ret) {
interestingFunction(_, f) and
returnStmt(f, ret)
}
private int getFunctionValue(Function f) {
interestingFunction(_, f)
and
// All returns must have the same int value
// And it must have at least one return
forex(Expr ret | returnStmt(f, ret) | result = getValueInternalNonSubExpr(ret))
forex(Expr ret | interestingReturnValue(f, ret) | result = getValueInternalNonSubExpr(ret))
}
/**