mirror of
https://github.com/github/codeql.git
synced 2025-12-21 11:16:30 +01:00
Update TimingAttackAgainstHeader.qhelp
This commit is contained in:
committed by
Chris Smowton
parent
ab6a7bb3d8
commit
bf95e59b24
@@ -3,9 +3,9 @@
|
|||||||
|
|
||||||
<overview>
|
<overview>
|
||||||
<p>
|
<p>
|
||||||
A constant-time algorithm should be used for checking the value of headers.
|
A constant-time algorithm should be used for checking the value of sensitive headers.
|
||||||
In other words, the comparison time should not depend on the content of the input.
|
In other words, the comparison time should not depend on the content of the input.
|
||||||
An attacker may be able to forge the value of the header.
|
Otherwise timing information could be used to infer the header's expected, secret value.
|
||||||
</p>
|
</p>
|
||||||
</overview>
|
</overview>
|
||||||
|
|
||||||
@@ -19,7 +19,7 @@ and does not depend on the contents of the arrays.
|
|||||||
</recommendation>
|
</recommendation>
|
||||||
<example>
|
<example>
|
||||||
<p>
|
<p>
|
||||||
The following example uses <code>Arrays.equals()</code> method for validating a csrf token .
|
The following example uses <code>Arrays.equals()</code> method for validating a csrf token.
|
||||||
This method implements a non-constant-time algorithm.
|
This method implements a non-constant-time algorithm.
|
||||||
Both the message and the signature come from an untrusted HTTP request:
|
Both the message and the signature come from an untrusted HTTP request:
|
||||||
</p>
|
</p>
|
||||||
|
|||||||
Reference in New Issue
Block a user