hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5253 from RasmusWL/no-getAnArg

Browse Source 
Approved by tausbn
This commit is contained in:
CodeQL CI
2021-02-24 06:34:31 -08:00
committed by GitHub
parent a05904f812 d05a8b8c46
commit bf66bdbb95
2 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
python/ql/src/Security/CWE-295/MissingHostKeyValidation.ql
View File

@@ -24,8 +24,9 @@ private API::Node paramikoSSHClientInstance() {
from DataFlow::CallCfgNode call, DataFlow::Node arg, string name
where
// see http://docs.paramiko.org/en/stable/api/client.html#paramiko.client.SSHClient.set_missing_host_key_policy
call = paramikoSSHClientInstance().getMember("set_missing_host_key_policy").getACall() and
arg = call.getAnArg() and
arg in [call.getArg(0), call.getArgByName("policy")] and
(
arg = unsafe_paramiko_policy(name).getAUse() or
arg = unsafe_paramiko_policy(name).getReturn().getAUse()

7
python/ql/src/semmle/python/dataflow/new/internal/DataFlowPublic.qll
View File

@@ -193,13 +193,6 @@ class CallCfgNode extends CfgNode {
/** Gets the data-flow node corresponding to the named argument of the call corresponding to this data-flow node */
Node getArgByName(string name) { result.asCfgNode() = node.getArgByName(name) }
/** Gets the data-flow node corresponding to an argument of the call corresponding to this data-flow node */
Node getAnArg() {
exists(int n | result = this.getArg(n))
or
exists(string name | result = this.getArgByName(name))
}
}
/**