hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 02:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3897 from aibaars/util-objects

Browse Source 
Java: data flow for `java.util.Objects`
This commit is contained in:
Anders Schack-Mulligen
2020-07-08 15:07:50 +02:00
committed by GitHub
parent 528f250af3 72a24972e7
commit bf5c5297d3
5 changed files with 56 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
java/ql/test/library-tests/dataflow/local-flow/ObjectsTest.java Normal file
View File

@@ -0,0 +1,14 @@
import java.util.Objects;
class ObjectsTest {
public static void valueSteps() {
sink(Objects.requireNonNull(source()));
sink(Objects.requireNonNull(source(), "message"));
sink(Objects.requireNonNull(source(), () -> "value1"));
sink(Objects.requireNonNullElse(source(), source()));
sink(Objects.requireNonNullElseGet(source(), () -> "value2"));
sink(Objects.toString(null, source()));
}
private static <T> T source() { return null; }
private static void sink(Object o) {}
}

7
java/ql/test/library-tests/dataflow/local-flow/flow.expected Normal file
View File

@@ -0,0 +1,7 @@
| ObjectsTest.java:5:31:5:38 | source(...) | ObjectsTest.java:5:8:5:39 | requireNonNull(...) |
| ObjectsTest.java:6:31:6:38 | source(...) | ObjectsTest.java:6:8:6:50 | requireNonNull(...) |
| ObjectsTest.java:7:31:7:38 | source(...) | ObjectsTest.java:7:8:7:55 | requireNonNull(...) |
| ObjectsTest.java:8:35:8:42 | source(...) | ObjectsTest.java:8:8:8:53 | requireNonNullElse(...) |
| ObjectsTest.java:8:45:8:52 | source(...) | ObjectsTest.java:8:8:8:53 | requireNonNullElse(...) |
| ObjectsTest.java:9:38:9:45 | source(...) | ObjectsTest.java:9:8:9:62 | requireNonNullElseGet(...) |
| ObjectsTest.java:10:31:10:38 | source(...) | ObjectsTest.java:10:8:10:39 | toString(...) |

21
java/ql/test/library-tests/dataflow/local-flow/flow.ql Normal file
View File

@@ -0,0 +1,21 @@
import java
import semmle.code.java.dataflow.DataFlow
class Conf extends DataFlow::Configuration {
Conf() { this = "conf" }
override predicate isSource(DataFlow::Node src) {
src.asExpr().(MethodAccess).getMethod().hasName("source")
}
override predicate isSink(DataFlow::Node sink) {
exists(MethodAccess ma |
sink.asExpr() = ma.getAnArgument() and
ma.getMethod().hasName("sink")
)
}
}
from Conf c, DataFlow::Node src, DataFlow::Node sink
where c.hasFlow(src, sink)
select src, sink

1
java/ql/test/library-tests/dataflow/local-flow/options Normal file
View File

@@ -0,0 +1 @@
//semmle-extractor-options: --javac-args -source 14 -target 14