hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-24 00:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Removed exclusion of FunctionExpr from compound statements.

Browse Source
This commit is contained in:
Napalys Klicius
2025-06-02 17:35:23 +02:00
parent 1f256ab71e
commit bf48b59874
3 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
javascript/ql/lib/Expressions/ExprHasNoEffect.qll
View File

@@ -139,8 +139,7 @@ predicate isCompoundExpression(Expr e) {
or
e instanceof SeqExpr
or
e instanceof ParExpr and
not e.stripParens() instanceof FunctionExpr
e instanceof ParExpr
}
/**

1
javascript/ql/test/query-tests/Expressions/ExprHasNoEffect/ExprHasNoEffect.expected
View File

@@ -12,4 +12,3 @@
| tst.js:50:3:50:36 | new Err ... age(e)) | This expression has no effect. |
| tst.js:61:2:61:20 | o.trivialNonGetter1 | This expression has no effect. |
| tst.js:77:24:77:24 | o | This expression has no effect. |
| uselessfn.js:1:1:1:26 | (functi ... .");\\n}) | This expression has no effect. |

4
javascript/ql/test/query-tests/Expressions/ExprHasNoEffect/uselessfn.js
View File

@@ -1,3 +1,3 @@
(function f() { // $ Alert
(function f() { // $MISSING: Alert
console.log("I'm never called.");
})
})