hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 09:15:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: Address review comments

Browse Source
This commit is contained in:
Taus
2025-03-04 22:30:55 +00:00
parent 83cdcdbb0b
commit bf3d9ee6a9
2 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
python/ql/lib/semmle/python/Function.qll
View File

@@ -165,12 +165,18 @@ class Function extends Function_, Scope, AstNode {
}
/** Gets the minimum number of positional arguments that can be correctly passed to this function. */
int getMinArguments() {
int getMinPositionalArguments() {
result = count(this.getAnArg()) - count(this.getDefinition().getArgs().getADefault())
}
/** Gets the maximum number of positional arguments that can be correctly passed to this function. */
int getMaxArguments() {
/**
* Gets the maximum number of positional arguments that can be correctly passed to this function.
*
* If the function has a `*vararg` parameter, there is no upper limit on the number of positional
* arguments that can be passed to the function. In this case, this method returns a very large
* number (currently `INT_MAX`, 2147483647, but this may change in the future).
*/
int getMaxPositionalArguments() {
if exists(this.getVararg())
then result = 2147483647 // INT_MAX
else result = count(this.getAnArg())

4
python/ql/lib/semmle/python/objects/ObjectAPI.qll
View File

@@ -738,9 +738,9 @@ class PythonFunctionValue extends FunctionValue {
else result = "function " + this.getQualifiedName()
}
override int minParameters() { result = this.getScope().getMinArguments() }
override int minParameters() { result = this.getScope().getMinPositionalArguments() }
override int maxParameters() { result = this.getScope().getMaxArguments() }
override int maxParameters() { result = this.getScope().getMaxPositionalArguments() }
/** Gets a control flow node corresponding to a return statement in this function */
ControlFlowNode getAReturnedNode() { result = this.getScope().getAReturnValueFlowNode() }