hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: Model concat() calls as string concatenation

Browse Source
This commit is contained in:
Asger Feldthaus
2020-02-04 10:20:37 +00:00
parent d995d5a4a0
commit bf2c944b4f
5 changed files with 41 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
javascript/ql/src/semmle/javascript/StringConcatenation.qll
View File

@@ -51,6 +51,17 @@ module StringConcatenation {
call = Closure::moduleImport("goog.string.buildString").getACall() and
result = call.getArgument(n)
)
or
exists(DataFlow::MethodCallNode call |
node = call and
call.getMethodName() = "concat" and
(
n = 0 and
result = call.getReceiver()
or
result = call.getArgument(n - 1)
)
)
}
/** Gets an operand to the string concatenation defining `node`. */

4
javascript/ql/test/library-tests/StringConcatenation/ClassContainsTwo.expected
View File

@@ -42,3 +42,7 @@
| tst.js:89:3:89:3 | x |
| tst.js:89:3:89:14 | x += 'three' |
| tst.js:90:10:90:10 | x |
| tst.js:95:3:95:30 | x = x.c ... three') |
| tst.js:95:7:95:30 | x.conca ... three') |
| tst.js:95:16:95:20 | 'two' |
| tst.js:96:10:96:10 | x |

4
javascript/ql/test/library-tests/StringConcatenation/ContainsTwo.expected
View File

@@ -42,3 +42,7 @@
| tst.js:89:3:89:3 | x |
| tst.js:89:3:89:14 | x += 'three' |
| tst.js:90:10:90:10 | x |
| tst.js:95:3:95:30 | x = x.c ... three') |
| tst.js:95:7:95:30 | x.conca ... three') |
| tst.js:95:16:95:20 | 'two' |
| tst.js:96:10:96:10 | x |

16
javascript/ql/test/library-tests/StringConcatenation/StringOps.expected
View File

@@ -45,6 +45,7 @@ concatenation
| tst.js:87:5:87:14 | x += 'two' |
| tst.js:89:3:89:14 | x |
| tst.js:89:3:89:14 | x += 'three' |
| tst.js:95:7:95:30 | x.conca ... three') |
concatenationOperand
| closure.js:5:1:5:37 | build(' ... 'four') |
| closure.js:5:7:5:11 | 'one' |
@@ -123,6 +124,9 @@ concatenationOperand
| tst.js:87:10:87:14 | 'two' |
| tst.js:89:3:89:3 | x |
| tst.js:89:8:89:14 | 'three' |
| tst.js:95:7:95:7 | x |
| tst.js:95:16:95:20 | 'two' |
| tst.js:95:23:95:29 | 'three' |
concatenationLeaf
| closure.js:5:7:5:11 | 'one' |
| closure.js:5:14:5:18 | 'two' |
@@ -192,6 +196,9 @@ concatenationLeaf
| tst.js:87:10:87:14 | 'two' |
| tst.js:89:3:89:3 | x |
| tst.js:89:8:89:14 | 'three' |
| tst.js:95:7:95:7 | x |
| tst.js:95:16:95:20 | 'two' |
| tst.js:95:23:95:29 | 'three' |
concatenationNode
| closure.js:5:1:5:37 | build(' ... 'four') |
| closure.js:5:1:5:46 | build(' ... 'five' |
@@ -307,6 +314,10 @@ concatenationNode
| tst.js:89:3:89:14 | x |
| tst.js:89:3:89:14 | x += 'three' |
| tst.js:89:8:89:14 | 'three' |
| tst.js:95:7:95:7 | x |
| tst.js:95:7:95:30 | x.conca ... three') |
| tst.js:95:16:95:20 | 'two' |
| tst.js:95:23:95:29 | 'three' |
operand
| closure.js:5:1:5:37 | build(' ... 'four') | 0 | closure.js:5:7:5:11 | 'one' |
| closure.js:5:1:5:37 | build(' ... 'four') | 1 | closure.js:5:14:5:28 | 'two' + 'three' |
@@ -407,6 +418,9 @@ operand
| tst.js:89:3:89:14 | x | 1 | tst.js:89:8:89:14 | 'three' |
| tst.js:89:3:89:14 | x += 'three' | 0 | tst.js:89:3:89:3 | x |
| tst.js:89:3:89:14 | x += 'three' | 1 | tst.js:89:8:89:14 | 'three' |
| tst.js:95:7:95:30 | x.conca ... three') | 0 | tst.js:95:7:95:7 | x |
| tst.js:95:7:95:30 | x.conca ... three') | 1 | tst.js:95:16:95:20 | 'two' |
| tst.js:95:7:95:30 | x.conca ... three') | 2 | tst.js:95:23:95:29 | 'three' |
nextLeaf
| closure.js:5:7:5:11 | 'one' | closure.js:5:14:5:18 | 'two' |
| closure.js:5:14:5:18 | 'two' | closure.js:5:22:5:28 | 'three' |
@@ -450,6 +464,8 @@ nextLeaf
| tst.js:61:27:61:27 | x | tst.js:61:29:61:33 | last |
| tst.js:87:5:87:5 | x | tst.js:87:10:87:14 | 'two' |
| tst.js:89:3:89:3 | x | tst.js:89:8:89:14 | 'three' |
| tst.js:95:7:95:7 | x | tst.js:95:16:95:20 | 'two' |
| tst.js:95:16:95:20 | 'two' | tst.js:95:23:95:29 | 'three' |
htmlRoot
| html-concat.js:2:14:2:26 | `<b>${x}</b>` |
| html-concat.js:3:14:3:26 | `<B>${x}</B>` |

6
javascript/ql/test/library-tests/StringConcatenation/tst.js
View File

@@ -89,3 +89,9 @@ function addExprPhi(b) {
x += 'three';
return x;
}
function concatCall() {
let x = 'one';
x = x.concat('two', 'three');
return x;
}