hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 18:55:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

add query for detecting uses return-values from functions that does not return a value

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2019-09-23 18:25:18 +02:00
parent 24a5301d87
commit bed14244ae
7 changed files with 186 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javascript/ql/test/query-tests/Statements/UseOfReturnlessFunction/UseOfReturnlessFunction.expected Normal file
View File

@@ -0,0 +1,2 @@
| tst.js:20:17:20:33 | onlySideEffects() | the function $@ does not return anything, yet the return value is used. | tst.js:11:5:13:5 | functio ... )\\n } | onlySideEffects |
| tst.js:24:13:24:29 | onlySideEffects() | the function $@ does not return anything, yet the return value is used. | tst.js:11:5:13:5 | functio ... )\\n } | onlySideEffects |

1
javascript/ql/test/query-tests/Statements/UseOfReturnlessFunction/UseOfReturnlessFunction.qlref Normal file
View File

@@ -0,0 +1 @@
Statements/UseOfReturnlessFunction.ql

26
javascript/ql/test/query-tests/Statements/UseOfReturnlessFunction/tst.js Normal file
View File

@@ -0,0 +1,26 @@
(function () {
function stub() {
throw new Error("Not implemented!");
}
function returnsValue() {
var x = 3;
return x * 2;
}
function onlySideEffects() {
console.log("Boo!")
}
var arrow = () => onlySideEffects();
console.log(returnsValue())
console.log(stub())
console.log(onlySideEffects()); // Not OK!
var a = Math.random() > 0.5 ? returnsValue() : onlySideEffects(); // OK! A is never used.
var b = onlySideEffects();
console.log(b);
})();