hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: Make Client::HttpRequest extend ControlFlowNode

Browse Source 
Taus poitned out that the reuqest being send off, doesn't *need* to happen on a
CallNode. Someone *could* use a __setattr__ or property :\
This commit is contained in:
Rasmus Wriedt Larsen
2020-02-25 16:09:32 +01:00
parent e25079acc2
commit be187bcc0a
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
python/ql/src/semmle/python/web/Http.qll
View File

@@ -121,7 +121,7 @@ module Client {
* conn = HTTPConnection('example.com')
conn.request('GET', '/path')
*/
abstract class HttpRequest extends CallNode {
abstract class HttpRequest extends ControlFlowNode {
/** Get any ControlFlowNode that is used to construct the final URL.
*

2
python/ql/src/semmle/python/web/client/Requests.qll
View File

@@ -6,7 +6,7 @@
import python
private import semmle.python.web.Http
class RequestsHttpRequest extends Client::HttpRequest {
class RequestsHttpRequest extends Client::HttpRequest, CallNode {
CallableValue func;
string method;

2
python/ql/src/semmle/python/web/client/StdLib.qll
View File

@@ -18,7 +18,7 @@ ClassValue httpConnectionClass() {
result = Value::named("six.moves.http_client.HTTPSConnection")
}
class HttpConnectionHttpRequest extends Client::HttpRequest {
class HttpConnectionHttpRequest extends Client::HttpRequest, CallNode {
CallNode constructor_call;
CallableValue func;