hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

add support for OptionalUse in js/missing-await

Browse Source
This commit is contained in:
Erik Krogh Kristensen
2020-10-20 16:52:57 +02:00
parent 8b084ffe22
commit bdbc8f5c91
3 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
javascript/ql/src/Expressions/MissingAwait.ql
View File

@@ -13,20 +13,20 @@ import javascript
/** /**
* Holds if `call` is a call to an `async` function. * Holds if `call` is a call to an `async` function.
*/ */
predicate isAsyncCall(DataFlow::CallNode call) { predicate isAsyncCall(DataFlow::CallNode call, boolean nullable) {
// If a callee is known, and all known callees are async, assume all // If a callee is known, and all known callees are async, assume all
// possible callees are async. // possible callees are async.
forex(Function callee | call.getACallee() = callee | callee.isAsync()) forex(Function callee | call.getACallee() = callee | callee.isAsync()) and
if call.asExpr() instanceof OptionalUse then nullable = true else nullable = false
} }
/** /**
* Holds if `node` is always a promise. * Holds if `node` is always a promise.
*/ */
predicate isPromise(DataFlow::SourceNode node, boolean nullable) { predicate isPromise(DataFlow::SourceNode node, boolean nullable) {
isAsyncCall(node) and isAsyncCall(node, nullable)
nullable = false
or or
not isAsyncCall(node) and not isAsyncCall(node, _) and
node.asExpr().getType() instanceof PromiseType and node.asExpr().getType() instanceof PromiseType and
nullable = true nullable = true
} }

1
javascript/ql/test/query-tests/Expressions/MissingAwait/MissingAwait.expected
View File

@@ -7,3 +7,4 @@
| tst.js:22:15:22:19 | thing | Missing await. The value 'thing' is always a promise. | | tst.js:22:15:22:19 | thing | Missing await. The value 'thing' is always a promise. |
| tst.js:25:13:25:17 | thing | Missing await. The value 'thing' is always a promise. | | tst.js:25:13:25:17 | thing | Missing await. The value 'thing' is always a promise. |
| tst.js:48:12:48:16 | thing | Missing await. The value 'thing' is always a promise. | | tst.js:48:12:48:16 | thing | Missing await. The value 'thing' is always a promise. |
| tst.js:71:16:71:25 | getThing() | Missing await. The call to 'getThing' always returns a promise. |

8
javascript/ql/test/query-tests/Expressions/MissingAwait/tst.js
View File

@@ -65,3 +65,11 @@ function useThingPossiblySync(b) {
function useThingInVoid() { function useThingInVoid() {
void getThing(); // OK void getThing(); // OK
} }
function useThing() {
if (random()) {
return getThing() ?? null; // NOT OK
} else {
return getThing?.() ?? null; // OK
}
}