hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-24 04:36:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: Workaround to get the tests passing again.

Browse Source
This commit is contained in:
Geoffrey White
2024-02-27 16:41:39 +00:00
parent 5787dcc82d
commit bc42e2bc35
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
cpp/ql/lib/semmle/code/cpp/dataflow/internal/FlowSummaryImpl.qll
View File

@@ -65,7 +65,10 @@ module Input implements InputSig<DataFlowImplSpecific::CppDataFlow> {
private import Make<DataFlowImplSpecific::CppDataFlow, Input> as Impl
private module StepsInput implements Impl::Private::StepsInputSig {
DataFlowCall getACall(Public::SummarizedCallable sc) { result.getStaticCallTarget() = TSummarizedCallable(sc) }
DataFlowCall getACall(Public::SummarizedCallable sc) {
result.getStaticCallTarget().asSourceCallable() = sc or
result.getStaticCallTarget().asSummarizedCallable() = sc // TODO: this should be the only case
}
}
module SourceSinkInterpretationInput implements
@@ -114,7 +117,8 @@ module SourceSinkInterpretationInput implements
Node asNode() { this = TNode_(result) }
/** Gets the call that this node corresponds to, if any. */
DataFlowCall asCall() { this.asElement() = result.asCallInstruction().getUnconvertedResultExpression()
DataFlowCall asCall() {
this.asElement() = result.asCallInstruction().getUnconvertedResultExpression()
// TODO: or summary call?
}

2
cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll
View File

@@ -951,7 +951,7 @@ class CastNode extends Node {
cached
newtype TDataFlowCallable =
TSourceCallable(Cpp::Declaration decl) { not decl instanceof FlowSummaryImpl::Public::SummarizedCallable } or
TSourceCallable(Cpp::Declaration decl) /*{ not decl instanceof FlowSummaryImpl::Public::SummarizedCallable }*/ or // TODO: figure this out
TSummarizedCallable(FlowSummaryImpl::Public::SummarizedCallable c)
/**