hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-03 12:45:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

JS: add missing binding for this in BuiltinServiceCall

Browse Source
This commit is contained in:
Esben Sparre Andreasen
2019-08-05 14:10:21 +02:00
parent bc296e74a1
commit bc2785d143
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
javascript/ql/src/semmle/javascript/frameworks/AngularJS/AngularJSCore.qll
View File

@@ -719,7 +719,8 @@ private class BuiltinServiceCall extends AngularJSCall {
BuiltinServiceCall() {
exists(BuiltinServiceReference service |
service.getAMethodCall(_) = this or
service.getACall() = this |
service.getACall() = this
|
call = this
)
}
@@ -769,7 +770,8 @@ private class BuiltinServiceCall extends AngularJSCall {
methodName = "$watchCollection" or
methodName = "$watchGroup"
|
e = scope.getAMethodCall(methodName).getArgument(0)
call = scope.getAMethodCall(methodName) and
e = call.getArgument(0)
)
or
exists(ServiceReference service |
@@ -777,15 +779,16 @@ private class BuiltinServiceCall extends AngularJSCall {
service.getName() = "$parse" or
service.getName() = "$interpolate"
|
e = service.getACall().getArgument(0)
call = service.getACall() and
e = call.getArgument(0)
)
or
exists(ServiceReference service, CallExpr filter, CallExpr filterInvocation |
exists(ServiceReference service, CallExpr filterInvocation |
// `$filter('orderBy')(collection, expression)`
service.getName() = "$filter" and
filter = service.getACall() and
filter.getArgument(0).mayHaveStringValue("orderBy") and
filterInvocation.getCallee() = filter and
call = service.getACall() and
call.getArgument(0).mayHaveStringValue("orderBy") and
filterInvocation.getCallee() = call and
e = filterInvocation.getArgument(1)
)
}