hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-23 18:33:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

Address comments

Browse Source
This commit is contained in:
Arthur Baars
2021-02-09 13:54:46 +01:00
parent a752491c5f
commit bb89e134c4
6 changed files with 65 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ql/src/codeql_ruby/ast/Statement.qll
View File

@@ -39,11 +39,7 @@ class Statement extends AstNode {
class ReturningStatement extends Statement {
override ReturningStatement::Range range;
final override string toString() {
not exists(getValue()) and result = range.getStatementName()
or
result = range.getStatementName() + " " + getValue().toString()
}
final override string toString() { result = range.toString() }
/** Gets the returned value, if any. */
final Expr getValue() {

8
ql/src/codeql_ruby/ast/internal/Statement.qll
View File

@@ -8,8 +8,6 @@ module Statement {
module ReturningStatement {
abstract class Range extends Statement::Range {
abstract Generated::ArgumentList getArgumentList();
abstract string getStatementName();
}
}
@@ -17,7 +15,7 @@ module ReturnStmt {
class Range extends ReturningStatement::Range, @return {
final override Generated::Return generated;
final override string getStatementName() { result = "return" }
final override string toString() { result = "return" }
final override Generated::ArgumentList getArgumentList() { result = generated.getChild() }
}
@@ -27,7 +25,7 @@ module BreakStmt {
class Range extends ReturningStatement::Range, @break {
final override Generated::Break generated;
final override string getStatementName() { result = "break" }
final override string toString() { result = "break" }
final override Generated::ArgumentList getArgumentList() { result = generated.getChild() }
}
@@ -37,7 +35,7 @@ module NextStmt {
class Range extends ReturningStatement::Range, @next {
final override Generated::Next generated;
final override string getStatementName() { result = "next" }
final override string toString() { result = "next" }
final override Generated::ArgumentList getArgumentList() { result = generated.getChild() }
}