From b8bd40463e1c2c1f7195ca933c8e303ef62c6dfb Mon Sep 17 00:00:00 2001 From: Owen Mansel-Chan Date: Wed, 20 Oct 2021 09:30:54 +0100 Subject: [PATCH] Reorder MISSING labels The behaviour has changed: previously, "f+:" and "f-:" only affected the following entry, but "MISSING:" and "SPURIOUS:" affect all following --- .../semmle/go/dataflow/PromotedMethods/methods.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ql/test/library-tests/semmle/go/dataflow/PromotedMethods/methods.go b/ql/test/library-tests/semmle/go/dataflow/PromotedMethods/methods.go index 3cbdbf58c98..ab523f9bc0e 100644 --- a/ql/test/library-tests/semmle/go/dataflow/PromotedMethods/methods.go +++ b/ql/test/library-tests/semmle/go/dataflow/PromotedMethods/methods.go @@ -23,7 +23,7 @@ func (e Embedded) sinkFieldOnEmbeddedNonPointerReceiver() { } func (e *Embedded) sinkFieldOnEmbeddedPointerReceiver() { - sink(e.field) // $MISSING:promotedmethods=nonPointerSender1 $MISSING:promotedmethods=pointerSender1 $MISSING:promotedmethods=nonPointerSender2 $MISSING:promotedmethods=pointerSender2 + sink(e.field) // $MISSING:promotedmethods=nonPointerSender1 $promotedmethods=pointerSender1 $promotedmethods=nonPointerSender2 $promotedmethods=pointerSender2 } func (base1 Base1) sinkFieldOnBase1NonPointerReceiver() { @@ -31,7 +31,7 @@ func (base1 Base1) sinkFieldOnBase1NonPointerReceiver() { } func (base1 *Base1) sinkFieldOnBase1PointerReceiver() { - sink(base1.field) // $MISSING:promotedmethods=nonPointerSender1 $promotedmethods=pointerSender1 + sink(base1.field) // $promotedmethods=pointerSender1 $MISSING:promotedmethods=nonPointerSender1 } func (base2 Base2) sinkFieldOnBase2NonPointerReceiver() { @@ -39,7 +39,7 @@ func (base2 Base2) sinkFieldOnBase2NonPointerReceiver() { } func (base2 *Base2) sinkFieldOnBase2PointerReceiver() { - sink(base2.field) // $MISSING:promotedmethods=nonPointerSender2 $promotedmethods=pointerSender2 + sink(base2.field) // $promotedmethods=pointerSender2 $MISSING:promotedmethods=nonPointerSender2 } func nonPointerSender1() {