hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-21 11:16:30 +01:00
Code Issues Packages Projects Releases Wiki Activity

C++: Restrict the side effect of StoreChainEndInstructionSideEffect to be WriteSideEffectInstructions

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2020-06-03 09:28:06 +02:00
parent ce34d91a07
commit b890b162f4
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cpp/ql/src/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll
View File

@@ -435,13 +435,13 @@ private Instruction skipConversion(Instruction instr) {
* before entering `setter`. * before entering `setter`.
*/ */
private class StoreChainEndInstructionSideEffect extends StoreChainEndInstruction, ChiInstruction { private class StoreChainEndInstructionSideEffect extends StoreChainEndInstruction, ChiInstruction {
SideEffectInstruction sideEffect; WriteSideEffectInstruction sideEffect;
FieldAddressInstruction fi; FieldAddressInstruction fi;
StoreChainEndInstructionSideEffect() { StoreChainEndInstructionSideEffect() {
not this.isResultConflated() and not this.isResultConflated() and
this.getPartial() = sideEffect and this.getPartial() = sideEffect and
fi = skipConversion*(sideEffect.getAnOperand().getDef()) fi = skipConversion*(sideEffect.getArgumentDef())
} }
override FieldAddressInstruction getFieldInstruction() { result = fi } override FieldAddressInstruction getFieldInstruction() { result = fi }