Apply suggestions from code review

Co-Authored-By: Max Schaefer <54907921+max-schaefer@users.noreply.github.com>
This commit is contained in:
Asger F
2020-01-30 12:42:58 +00:00
committed by GitHub
parent 1bf8165098
commit b88cc50cdb
2 changed files with 5 additions and 5 deletions

View File

@@ -397,7 +397,7 @@ public class AutoBuild {
for (FileType filetype : defaultExtract)
for (String extension : filetype.getExtensions()) patterns.add("**/*" + extension);
// include .eslintrc files and package.json files
// include .eslintrc files, package.json files, and tsconfig.json files
patterns.add("**/.eslintrc*");
patterns.add("**/package.json");
patterns.add("**/tsconfig.json");
@@ -601,7 +601,7 @@ public class AutoBuild {
}
/**
* Returns an existing file named <code>dir/stem.ext</code> where <code>ext</code> is any
* Returns an existing file named <code>dir/stem.ext</code> where <code>.ext</code> is any
* of the given extensions, or <code>null</code> if no such file exists.
*/
private static Path tryResolveWithExtensions(Path dir, String stem, Iterable<String> extensions) {
@@ -708,7 +708,7 @@ public class AutoBuild {
// Remove dependency on local package
propsToRemove.add(packageName);
} else {
// Remove file dependency on a package that don't exist in the checkout.
// Remove file dependency on a package that doesn't exist in the checkout.
String dependency = getChildAsString(dependencyObj, packageName);
if (dependency != null && (dependency.startsWith("file:") || dependency.startsWith("./") || dependency.startsWith("../"))) {
if (dependency.startsWith("file:")) {